Horton

Re: tuplesort_gettuple_common() and *should_free argument

Peter Geoghegan <pg@heroku.com>

View thread View on postgr.es
From: Peter Geoghegan <pg@heroku.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2016-12-08T20:30:52Z
Lists: pgsql-hackers 
On Wed, Dec 7, 2016 at 11:55 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Should we be worried about breaking the API of tuplesort_get* functions?
> They might be used by extensions. I think that's OK, but wanted to bring it
> up. This would be only for master, of course, and any breakage would be
> straightforward to fix.

I don't think so. I'm not aware of any third party extensions that
call tuplesort.c routines, despite having looked for them. I noticed
that pg_repack doesn't. For any that do, they'll break in a
predictable, obvious way.

-- 
Peter Geoghegan

Commits

  1. Fix duplicated words in comment.

  2. Remove should_free arguments to tuplesort routines.

  3. Fix use-after-free around DISTINCT transition function calls.