Horton

Re: Inconsistency in reporting checkpointer stats

Gregory Stark (as CFM) <stark.cfm@gmail.com>

View thread View on postgr.es
From: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-20T20:01:02Z
Lists: pgsql-hackers 
On Sun, 19 Feb 2023 at 04:58, Nitin Jadhav
<nitinjadhavpostgres@gmail.com> wrote:
>
> > This doesn't pass the tests, because the regression tests weren't adjusted:
> > https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
>
> Thanks for sharing this. I have fixed this in the patch attached.

AFAICS this patch was marked Waiting on Author due to this feedback on
Feb 14 but the patch was updated Feb 19 and is still passing today.
I've marked it Needs Review.

I'm not sure if all of the feedback from Bharath Rupireddy and Kyotaro
Horiguchi was addressed.

If there's any specific questions remaining you need feedback on it
would be good to ask explicitly. Otherwise if you think it's ready you
could mark it Ready for Commit.




-- 
Gregory Stark
As Commitfest Manager

Commits

  1. Fix inconsistent reporting of checkpointer stats.

  2. Defer flushing of SLRU files.