Horton

Re: Extending amcheck to check toast size and compression

Greg Stark <stark@mit.edu>

View thread View on postgr.es
From: Greg Stark <stark@mit.edu>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-20T18:42:35Z
Lists: pgsql-hackers 
On Wed., Oct. 20, 2021, 12:41 Mark Dilger, <mark.dilger@enterprisedb.com>
wrote:

>
> I used a switch statement to trigger a compiler warning in such an event.
>

Catching better compiler diagnostics is an excellent reason to choose this
structure. I guess all I could ask is that the comment saying no default
branch say this is the motivation.

>

Commits

  1. Remove tests added by bd807be6935929bdefe74d1258ca08048f0aafa3.

  2. amcheck: Add additional TOAST pointer checks.