Re: Removing unneeded self joins

Greg Stark <stark@mit.edu>

From: Greg Stark <stark@mit.edu>
To: "Andrey V. Lepikhov" <a.lepikhov@postgrespro.ru>
Cc: Andres Freund <andres@anarazel.de>, Ronan Dunklau <ronan.dunklau@aiven.io>, Laurenz Albe <laurenz.albe@cybertec.at>, Hywel Carver <hywel@skillerwhale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Konstantin Knizhnik <knizhnik@garret.ru>
Date: 2022-04-01T15:27:56Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Remove GUC_NOT_IN_SAMPLE from enable_self_join_elimination

  2. Put enable_self_join_elimination into postgresql.conf.sample

  3. Get rid of ojrelid local variable in remove_rel_from_query()

  4. Implement Self-Join Elimination

  5. Revert: Remove useless self-joins

  6. Replace lateral references to removed rels in subqueries

  7. Replace relids in lateral subquery parse tree during SJE

  8. Forbid SJE with result relation

  9. Fix misuse of RelOptInfo.unique_for_rels cache by SJE

  10. Replace the relid in some missing fields during SJE

  11. Revert 56-bit relfilenode change and follow-up commits.

  12. Stabilize timetz test across DST transitions.

  13. Speed up finding EquivalenceClasses for a given set of rels

  14. Fix mark-and-restore-skipping test case to not be a self-join.

Sigh. And now there's a patch conflict in a regression test expected
output: sysviews.out

Please rebase. Incidentally, make sure to check the expected output is
actually correct. It's easy to "fix" an expected output to
accidentally just memorialize an incorrect output.

Btw, it's the last week before feature freeze so time is of the essence.