Horton

Re: Re[3]: On login trigger: take three

Ibrar Ahmed <ibrar.ahmad@gmail.com>

View thread View on postgr.es
From: Ibrar Ahmed <ibrar.ahmad@gmail.com>
To: Greg Nancarrow <gregn4422@gmail.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Cc: vignesh C <vignesh21@gmail.com>, Ivan Panchenko <wao@mail.ru>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2021-07-19T10:17:43Z
Lists: pgsql-hackers 
On Wed, Jul 7, 2021 at 5:55 AM Greg Nancarrow <gregn4422@gmail.com> wrote:

> On Sun, Jul 4, 2021 at 1:21 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > CFBot shows the following failure:
> > # poll_query_until timed out executing this query:
> > # SELECT '0/3046250' <= replay_lsn AND state = 'streaming' FROM
> > pg_catalog.pg_stat_replication WHERE application_name = 'standby_1';
> > # expecting this output:
> > # t
> > # last actual query output:
> > # t
> > # with stderr:
> > # NOTICE: You are welcome!
> > # Looks like your test exited with 29 before it could output anything.
> > t/001_stream_rep.pl ..................
> > Dubious, test returned 29 (wstat 7424, 0x1d00)
> >
>
> Thanks.
> I found that the patch was broken by commit f452aaf7d (the part
> "adjust poll_query_until to insist on empty stderr as well as a stdout
> match").
> So I had to remove a "RAISE NOTICE" (which was just an informational
> message) from the login trigger function, to satisfy the new
> poll_query_until expectations.
> Also, I updated a PG14 version check (now must check PG15 version).
>
> Regards,
> Greg Nancarrow
> Fujitsu Australia
>


The patch does not apply, and rebase is required.

Hunk #1 FAILED at 93.
1 out of 1 hunk FAILED -- saving rejects to file
src/test/regress/expected/sysviews.out.rej


I am not changing the status because it is a minor change and the
patch is already "Ready for Committer".


-- 
Ibrar Ahmed

Commits

  1. Fix some typos in event trigger docs

  2. Use heap_inplace_update() to unset pg_database.dathasloginevt

  3. Remove the flaky check in event_trigger_login regression test

  4. Fix instable 006_login_trigger.pl test

  5. Add support event triggers on authenticated login

  6. Add GUC for temporarily disabling event triggers

  7. Fix typo in reference to __FreeBSD__.

  8. Restore robustness of TAP tests that wait for postmaster restart.

  9. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.