Horton

Re: pg_upgrade: Error out on too many command-line arguments

Ibrar Ahmed <ibrar.ahmad@gmail.com>

View thread View on postgr.es
From: Ibrar Ahmed <ibrar.ahmad@gmail.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-08-25T18:50:44Z
Lists: pgsql-hackers

Attachments

On Sun, Aug 25, 2019 at 8:39 PM Julien Rouhaud <rjuju123@gmail.com> wrote:

> On Sun, Aug 25, 2019 at 4:30 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > > I propose the attached patch to make pg_upgrade error out on too many
> > > command-line arguments.  This makes it match the behavior of other
> > > PostgreSQL programs.
> >
> > +1 ... are we missing this anywhere else?
>
> I did some searching, and oid2name.c is also missing this.
>
> Yes, "oid2name" missing that check too.



-- 
Ibrar Ahmed

Commits

  1. Error out on too many command-line arguments