Re: Disabled logical replication origin session causes primary key errors

Shawn McCoy <shawn.the.mccoy@gmail.com>

From: Shawn McCoy <shawn.the.mccoy@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, "drewwcallahan@gmail.com" <drewwcallahan@gmail.com>, "scott@meads.us" <scott@meads.us>

Date: 2025-04-22T20:10:02Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix an oversight in 3f28b2fcac.
- 0e091ce409e0 18.0 landed
- 05676d87e2e6 17.5 landed
- 0de091a4b585 16.9 landed
Don't advance origin during apply failure.
- 3f28b2fcac33 18.0 cited

> Thanks, Vignesh, for testing the fix. Shawn, it would be good if you
> could confirm the fix at your end as well.

I tested the patch and confirmed on versions 16.8, 17.4 and HEAD that
the pgbench / functional index version repro is indeed fixed.

Thanks,
Shawn