Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Euler Taveira <euler@eulerto.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-23T15:46:02Z
Lists: pgsql-hackers
On Thu, Dec 23, 2021 at 9:13 PM Euler Taveira <euler@eulerto.com> wrote: > > On Thu, Dec 23, 2021, at 8:39 AM, Bharath Rupireddy wrote: > > pg_control_checkpoint emits 18 columns whereas the values and nulls > arrays are defined to be of size 19. Although it's not critical, > attaching a tiny patch to fix this. > > Good catch! I'm wondering if a constant wouldn't be useful for such case. Thanks. I thought of having a macro, but it creates a lot of diff with the previous versions as we have to change for other pg_control_XXX functions. Regards, Bharath Rupireddy.
Commits
-
Fix incorrect field count in pg_control_checkpoint()
- 86d9888d2ead 15.0 landed
-
Fix pg_control_checkpoint from commit 4b0d28de06
- 2ede45c3a49e 11.0 cited
-
Remove secondary checkpoint
- 4b0d28de06b2 11.0 cited