Re: pg_log_backend_memory_contexts() and log level
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2022-01-26T05:20:53Z
Lists: pgsql-hackers
On Wed, Jan 26, 2022 at 10:46 AM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote: > > On Wed, Jan 26, 2022 at 9:48 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote: > > > > Hi, > > > > pg_log_backend_memory_contexts() should be designed not to send the messages about the memory contexts to the client regardless of client_min_messages. But I found that the message "logging memory contexts of PID %d" can be sent to the client because it's ereport()'d with LOG level instead of LOG_SERVER_ONLY. Is this a bug, and shouldn't we use LOG_SERVER_ONLY level to log that message? Patch attached. > > +1. The patch LGTM. > > The same applies for the on-going patch [1] for pg_log_backtrace, let > me quickly send the updated patch there as well. > > [1] - https://www.postgresql.org/message-id/CALDaNm3tbc1OKvSKvD5SfmEj66M_sWDPCgDvzFtS9gxRov8jRQ%40mail.gmail.com My bad, the v17 patch of pg_log_backtrace at [1] does emit at LOG_SERVER_ONLY. Regards, Bharath Rupireddy.
Commits
-
Prevent memory context logging from sending log message to connected client.
- 6e7ee55e7277 14.2 landed
- 108505d763d1 15.0 landed