Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Smith <smithpb2250@gmail.com>, Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-07-06T10:36:01Z

Lists: pgsql-hackers

Attachments

v10-0001-Remove-similar-ereport-calls-in-parse_subscripti.patch (application/octet-stream) patch v10-0001

On Tue, Jul 6, 2021 at 1:51 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > Okay, I'll push it early next week (by Tuesday) unless there are more
> > comments or suggestions. Thanks!
> >
>
> Pushed!

Thanks, Amit. I'm posting the 0002 patch which removes extra ereport
calls using local variables. Please review it.

Regards,
Bharath Rupireddy.

Commits

Refactor function parse_subscription_options.
- 8aafb0261675 15.0 landed
Refactor function parse_output_parameters.
- 531737ddad21 14.0 cited
Refactor option handling of CLUSTER, REINDEX and VACUUM
- a3dc926009be 14.0 cited
Add assertion to quiet Coverity
- b1ff33fd9bb8 10.0 cited