Re: pg_receivewal and SIGTERM
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Christoph Berg <myon@debian.org>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-16T11:40:54Z
Lists: pgsql-hackers
On Tue, Aug 16, 2022 at 5:06 PM Christoph Berg <myon@debian.org> wrote: > > Re: Daniel Gustafsson > > Do you think pg_recvlogical should support SIGTERM as well? (The signals which > > it does trap should be added to the documentation which just now says "until > > terminated by a signal" but that's a separate thing.) > > Ack, that makes sense, added in the attached updated patch. > > > pqsignal(SIGINT, sigint_handler); > > + pqsignal(SIGTERM, sigint_handler); > > Tiny nitpick, I think we should rename sigint_handler to just sig_handler as it > > does handle more than sigint. > > I went with sigexit_handler since pg_recvlogical has also a > sighup_handler and "sig_handler" would be confusing there. Can we move these signal handlers to streamutil.h/.c so that both pg_receivewal and pg_recvlogical can make use of it avoiding duplicate code? -- Bharath Rupireddy RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/
Commits
-
Handle SIGTERM in pg_receivewal and pg_recvlogical
- 8b60db774356 16.0 landed
-
doc: Add missing parenthesis to keycombo
- 6cbed0ec791f 16.0 landed
- 207fc7546644 15.0 landed