Re: Refactor backup related code (was: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?)

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

View thread View on postgr.es

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: David Steele <david@pgmasters.net>

Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-08-11T04:25:13Z

Lists: pgsql-hackers

Attachments

v2-0001-Refactor-backup-related-code.patch (application/octet-stream) patch v2-0001

On Mon, Aug 8, 2022 at 7:20 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> > Please review.
>
> I added this to current CF - https://commitfest.postgresql.org/39/3808/

Here's the v2 patch, no change from v1, just rebased because of commit
a8c012869763c711abc9085f54b2a100b60a85fa (Move basebackup code to new
directory src/backend/backup).

-- 
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/

Commits

Fix some comments of do_pg_backup_start() and do_pg_backup_stop()
- 2e560b974ec7 16.0 landed
Remove dependency to StringInfo in xlogbackup.{c.h}
- e1e6f8f3dfe1 16.0 landed
Refactor creation of backup_label and backup history files
- 7d708093b740 16.0 landed
Move basebackup code to new directory src/backend/backup
- a8c012869763 16.0 cited
Remove exclusive backup mode
- 39969e2a1e4d 15.0 cited