Horton

Re: Introduce a new view for checkpointer related stats

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

View thread View on postgr.es
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-30T06:34:33Z
Lists: pgsql-hackers

Attachments

On Wed, Nov 30, 2022 at 6:01 AM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2022-11-28 12:58:48 -0500, Robert Haas wrote:
> > On Tue, Nov 22, 2022 at 3:53 PM Andres Freund <andres@anarazel.de> wrote:
> > > I think we should consider deprecating the pg_stat_bgwriter columns but
> > > leaving them in place for a few years. New stuff should only be added to
> > > pg_stat_checkpointer, but we don't need to break old monitoring queries.
> >
> > I vote to just remove them. I think that most people won't update
> > their queries until they are forced to do so.
>
> Seems most agree with that... WFM.

Thanks. I'm attaching the v2 patch from upthread again here as we all
agree to remove checkpointer columns from pg_stat_bgwriter view and
have them in the new view pg_stat_checkpointer.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Expand regression tests for pg_stat_reset_shared()

  2. Introduce pg_stat_checkpointer

  3. Remove buffers_backend and buffers_backend_fsync from pg_stat_checkpointer