Re: Parallel copy

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: vignesh C <vignesh21@gmail.com>

Cc: Ashutosh Sharma <ashu.coek88@gmail.com>, Andres Freund <andres@anarazel.de>, Amit Kapila <amit.kapila16@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Ants Aasma <ants@cybertec.at>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alastair Turner <minion@decodable.me>, Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2020-06-25T03:00:14Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow WaitLatch() to be used without a latch.
- 733fa9aa51c5 14.0 cited
Add %P to log_line_prefix for parallel group leader
- b8fdee7d0ca8 14.0 cited
Include replication origins in SQL functions for commit timestamp
- b1e48bbe64a4 14.0 cited
Avoid useless buffer allocations during binary COPY FROM.
- cd22d3cdb9bd 14.0 cited

Attachments

0001-Copy-code-readjustment-to-support-parallel-copy.patch (application/octet-stream) patch 0001
0002-Framework-for-leader-worker-in-parallel-copy.patch (application/octet-stream) patch 0002
0003-Allow-copy-from-command-to-process-data-from-file-ST.patch (application/octet-stream) patch 0003
0004-Documentation-for-parallel-copy.patch (application/octet-stream) patch 0004
0005-Tests-for-parallel-copy.patch (application/octet-stream) patch 0005
0006-Parallel-Copy-For-Binary-Format-Files.patch (application/octet-stream) patch 0006

On Wed, Jun 24, 2020 at 2:16 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> Hi,
>
> It looks like the parsing of newly introduced "PARALLEL" option for
> COPY FROM command has an issue(in the
> 0002-Framework-for-leader-worker-in-parallel-copy.patch),
> Mentioning ....PARALLEL '4ar2eteid'); would pass with 4 workers since
> atoi() is being used for converting string to integer which just
> returns 4, ignoring other strings.
>
> I used strtol(), added error checks and introduced the error "
> improper use of argument to option "parallel"" for the above cases.
>
>         parallel '4ar2eteid');
> ERROR:  improper use of argument to option "parallel"
> LINE 5:         parallel '1\');
>
> Along with the updated patch
> 0002-Framework-for-leader-worker-in-parallel-copy.patch, also
> attaching all the latest patches from [1].
>
> [1] - https://www.postgresql.org/message-id/CALj2ACW94icER3WrWapon7JkcX8j0TGRue5ycWMTEvgA3X7fOg%40mail.gmail.com
>

I'm sorry, I forgot to attach the patches. Here are the latest series
of patches.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com