Re: Improve WALRead() to suck data directly from WAL buffers when possible

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Jeff Davis <pgsql@j-davis.com>

Cc: Andres Freund <andres@anarazel.de>, Dilip Kumar <dilipbalaut@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@lists.postgresql.org, Nathan Bossart <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>

Date: 2023-12-20T10:06:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add XLogCtl->logInsertResult
- f3ff7bf83bce 17.0 cited
Add assert to WALReadFromBuffers().
- 9ecbf54075a9 17.0 landed
Read WAL directly from WAL buffers.
- 91f2cae7a4e6 17.0 landed
Additional write barrier in AdvanceXLInsertBuffer().
- 766571be1659 17.0 landed
Use 64-bit atomics for xlblocks array elements.
- c3a8e2a7cb16 17.0 landed
Don't trust unvalidated xl_tot_len.
- bae868caf222 17.0 cited

Attachments

v18-0001-Allow-WAL-reading-from-WAL-buffers.patch (application/octet-stream) patch v18-0001
v18-0002-Add-test-module-for-verifying-WAL-read-from-WAL-.patch (application/octet-stream) patch v18-0002

On Fri, Dec 8, 2023 at 6:04 AM Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Thu, 2023-12-07 at 15:59 +0530, Bharath Rupireddy wrote:
> > In the attached v17 patch
>
> The code for 0001 itself looks good. These are minor concerns and I am
> inclined to commit something like it fairly soon.

Thanks. Attaching remaining patches as v18 patch-set after commits
c3a8e2a7cb16 and 766571be1659.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com