Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-27T16:26:37Z
Lists: pgsql-hackers
Hi,
Is there a specific reason that we have a generic WARNING "worker took
too long to start; canceled" for an autovacuum worker? Isn't it better
with "autovacuum worker took too long to start; canceled"? It is
confusing to see the generic message in the server logs while
debugging an issue for a user who doesn't know the internals of
autovacuum code.
To be more informative about the message, how about the following:
1) ereport(WARNING,
(errmsg( "worker took too long to start"),
errdetail("Previous attempt to start autovacuum
worker was failed, canceled.")));
or
2) ereport(WARNING,
(errmsg( "worker took too long to start, canceled"),
errdetail("The postmaster couldn't start an
autovacuum worker.")));
or
3) ereport(WARNING,
(errmsg( "worker took too long to start, canceled"),
errdetail("Previous attempt to start autovacuum
worker was failed.")));
or
4) elog(WARNING, "postmaster couldn't start an autovacuum worker");
Thoughts?
Regards,
Bharath Rupireddy.
Commits
-
autovacuum: Improve wording in a couple places
- 042412879e35 15.0 landed