Re: New Table Access Methods for Multi and Single Inserts

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Dilip Kumar <dilipbalaut@gmail.com>

Cc: Luc Vlaming <luc@swarm64.com>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, Paul Guo <guopa@vmware.com>, Jeff Davis <pgsql@j-davis.com>

Date: 2021-03-10T04:51:53Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

libpq: Fix some issues in TAP tests for service files
- 2c7bd2ba507e 18.0 cited
Multiple revisions to the GROUP BY reordering tests
- 874d817baa16 17.0 cited
Explore alternative orderings of group-by pathkeys during optimization.
- 0452b461bc40 17.0 cited

Attachments

v4-0001-New-Table-AMs-for-Multi-and-Single-Inserts.patch (application/x-patch) patch v4-0001
v4-0002-CTAS-and-REFRESH-Mat-View-With-New-Multi-Insert-T.patch (application/x-patch) patch v4-0002
v4-0003-COPY-With-New-Multi-and-Single-Insert-Table-AM.patch (application/x-patch) patch v4-0003

On Tue, Mar 9, 2021 at 1:45 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
> On Mon, Mar 8, 2021 at 6:37 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>>
> > Why do we need to invent a new version table_insert_v2?  And also why
> > it is named table_insert* instead of table_tuple_insert*?
>
> New version, because we changed the input parameters, now passing the
> params via TableInsertState but existing table_tuple_insert doesn't do
> that. If okay, I can change table_insert_v2  to table_tuple_insert_v2?
> Thoughts?

Changed table_insert_v2 to table_tuple_insert_v2. And also, rebased
the patches on to the latest master.

Attaching the v4 patch set. Please review it further.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com