Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Smith <smithpb2250@gmail.com>, Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-07-01T15:55:41Z

Lists: pgsql-hackers

Attachments

v11-0001-Refactor-function-parse_subscription_options.patch (application/octet-stream) patch v11-0001

On Thu, Jul 1, 2021 at 6:32 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > 3) There's an whitespace introduced making the SUBOPT_SLOT_NAME,
> > SUBOPT_SYNCHRONOUS_COMMIT and SUBOPT_STREAMING not falling line with
> > the SUBOPT_CONNECT
> >
>
> okay, will fix it.

PSA v11 patch which also has the cleanup patch shared by Alvaro Herrera.

Regards,
Bharath Rupireddy.

Commits

Refactor function parse_subscription_options.
- 8aafb0261675 15.0 landed
Refactor function parse_output_parameters.
- 531737ddad21 14.0 cited
Refactor option handling of CLUSTER, REINDEX and VACUUM
- a3dc926009be 14.0 cited
Add assertion to quiet Coverity
- b1ff33fd9bb8 10.0 cited