Horton

Thread

Commits

  1. Remove redundant variable pageSize in gistinitpage

  2. Add support for building GiST index by sorting.

  1. Remove redundant variable pageSize in gistinitpage

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2021-04-26T03:12:30Z

    Hi,

In gistinitpage, pageSize variable looks redundant, instead we could
just pass BLCKSZ. This will be consistent with its peers
BloomInitPage, brin_page_init and SpGistInitPage. Attaching a small
patch. Thoughts?

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

  2. Re: Remove redundant variable pageSize in gistinitpage

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2021-06-25T06:03:13Z

    On 26.04.21 05:12, Bharath Rupireddy wrote:
> In gistinitpage, pageSize variable looks redundant, instead we could
> just pass BLCKSZ. This will be consistent with its peers
> BloomInitPage, brin_page_init and SpGistInitPage. Attaching a small
> patch. Thoughts?

Committed.

This code was new in this form in PG14 
(16fa9b2b30a357b4aea982bd878ec2e5e002dbcc), so it made sense to clean it 
up now.