Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: Michael Paquier <michael@paquier.xyz>, Amit Kapila <amit.kapila16@gmail.com>, Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-06-10T13:06:50Z

Lists: pgsql-hackers

Attachments

v5-0001-Refactor-parse_subscription_options.patch (application/octet-stream) patch v5-0001
v5-0002-Remove-similar-ereport-calls-in-parse_subscriptio.patch (application/octet-stream) patch v5-0002

On Thu, Jun 10, 2021 at 9:17 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
> > I don't know the answer; my guess is that all this has become obsolete
> > and the whole Assert and the dodgy comment can just be deleted.
>
> Hm. I get it. Unfortunately the commit b1ff33f is missing information
> on what the coverity tool was complaining of and it has no related
> discussion at all.
>
> I agree to remove that assertion entirely. I will post a new patch set soon.

PSA v5 patch set.

With Regards,
Bharath Rupireddy.

Commits

Refactor function parse_subscription_options.
- 8aafb0261675 15.0 landed
Refactor function parse_output_parameters.
- 531737ddad21 14.0 cited
Refactor option handling of CLUSTER, REINDEX and VACUUM
- a3dc926009be 14.0 cited
Add assertion to quiet Coverity
- b1ff33fd9bb8 10.0 cited