Re: pg_receivewal and SIGTERM

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Christoph Berg <myon@debian.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-19T12:04:56Z
Lists: pgsql-hackers
On Fri, Aug 19, 2022 at 4:24 PM Christoph Berg <myon@debian.org> wrote:
>
> Re: Bharath Rupireddy
> >     <application>pg_receivewal</application> will exit with status 0 when
> > -   terminated by the <systemitem>SIGINT</systemitem> signal.  (That is the
> > +   terminated by the <systemitem>SIGINT</systemitem> or
> > +   <systemitem>SIGTERM</systemitem> signal.  (That is the
> >     normal way to end it.  Hence it is not an error.)  For fatal errors or
> >     other signals, the exit status will be nonzero.
> >
> > Can we specify the reason in the docs why a SIGTERM causes (which
> > typically would cause a program to end with non-zero exit code)
> > pg_receivewal and pg_recvlogical exit with zero exit code? Having this
> > in the commit message would help developers but the documentation will
> > help users out there.
>
> We could add "because you want that if it's running as a daemon", but

+1 to add "some" info in the docs (I'm not sure about the better
wording though), we can try to be more specific of the use case if
required.

-- 
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/



Commits

  1. Handle SIGTERM in pg_receivewal and pg_recvlogical

  2. doc: Add missing parenthesis to keycombo