Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?

On Thu, Apr 8, 2021 at 1:22 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Apr 08, 2021 at 07:45:25AM +0530, Bharath Rupireddy wrote:
> > On Wed, Apr 7, 2021 at 11:47 AM Bharath Rupireddy
> > <bharath.rupireddyforpostgres@gmail.com> wrote:
> >> I wanted to comment out p->pd_flags = 0; in PageInit similar to the
> >> pd_prune_xid just for consistency.
> >>     /* p->pd_prune_xid = InvalidTransactionId;        done by above MemSet */
> >
> > As I said above, just for consistency, I would like to see if the
> > attached one line patch can be taken, even though it doesn't have any
> > impact.
>
> FWIW, I tend to prefer the existing style to keep around this code
> rather than commenting it out, as one could think to remove it, but I
> think that it can be important in terms of code comprehension when
> reading the area.  So I quite like what 96ef3b8 has undone for
> pd_flags, but not much what cc59049 did back in 2007.  That's a matter
> of taste, really.

Thanks! Since the main patch is committed I will go ahead and close
the CF entry.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com