Horton

Thread

Commits

  1. Remove unnecessary assertion in postmaster.c

  2. Make archiver process an auxiliary process.

  1. Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2021-07-14T18:08:59Z

    Hi,

It looks like the commit d75288fb [1] added an unnecessary
Assert(PgArchPID == 0); in PostmasterStateMachine as the if block code
gets hit only when PgArchPID == 0. PSA small patch.

[1]
commit d75288fb27b8fe0a926aaab7d75816f091ecdc27
Author: Fujii Masao <fujii@postgresql.org>
Date:   Mon Mar 15 13:13:14 2021 +0900

    Make archiver process an auxiliary process.

Regards,
Bharath Rupireddy.

  2. Re: Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

    Michael Paquier <michael@paquier.xyz> — 2021-07-15T02:21:43Z

    On Wed, Jul 14, 2021 at 11:38:59PM +0530, Bharath Rupireddy wrote:
> It looks like the commit d75288fb [1] added an unnecessary
> Assert(PgArchPID == 0); in PostmasterStateMachine as the if block code
> gets hit only when PgArchPID == 0. PSA small patch.

Agreed that there is no need to keep that around.  Will fix.
--
Michael

  3. Re: Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-07-15T02:49:33Z

    
On 2021/07/15 11:21, Michael Paquier wrote:
> On Wed, Jul 14, 2021 at 11:38:59PM +0530, Bharath Rupireddy wrote:
>> It looks like the commit d75288fb [1] added an unnecessary
>> Assert(PgArchPID == 0); in PostmasterStateMachine as the if block code
>> gets hit only when PgArchPID == 0. PSA small patch.

Good catch, Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  4. Re: Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

    Michael Paquier <michael@paquier.xyz> — 2021-07-15T07:02:48Z

    On Thu, Jul 15, 2021 at 11:49:33AM +0900, Fujii Masao wrote:
> Good catch, Thanks!

Done while I was on it.
--
Michael