Re: Skip ExecCheckRTPerms in CTAS with no data

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2020-11-20T09:34:57Z

Lists: pgsql-hackers

Attachments

v1-0001-Do-not-check-INSERT-privilege-in-CTAS-and-MatView.patch (application/x-patch) patch v1-0001

On Fri, Nov 20, 2020 at 11:07 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> Thanks.  Based on what Peter has said, the ACL_INSERT check in
> intorel_startup() could just be removed, and the tests of matview.sql
> and select_into.sql would need some cleanup.  We could keep around
> some scenarios with some follow-up INSERT queries after the initial
> creation.
>

Thanks! Attaching the patch. Please review it.


With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Commits

Remove INSERT privilege check at table creation of CTAS and matview
- 878f3a19c6c8 14.0 landed
Relax INSERT privilege requirement for CTAS and matviews WITH NO DATA
- 846005e4f382 14.0 landed