Re: Add test module for Custom WAL Resource Manager feature

On Sat, Nov 12, 2022 at 4:40 AM Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Fri, 2022-11-11 at 17:01 +0530, Bharath Rupireddy wrote:
> > Hi,
> >
> > Inspired by recent commits 9fcdf2c, e813e0e and many small test
> > modules/extensions under src/test/modules, I would like to propose
> > one
> > such test module for Custom WAL Resource Manager feature introduced
> > by
> > commit 5c279a6. It not only covers the code a bit, but it also
> > demonstrates usage of the feature.
> >
> > I'm attaching a patch herewith. Thoughts?
>
> Good idea.

Thanks.

> Can we take it a little further to exercise the decoding
> path, as well? For instance, we can do something like a previous proposal[1], except
> it can now be done as an extension. If it's useful, we could even put
> it in contrib with a real RMGR ID.
>
> [1]
> https://www.postgresql.org/message-id/20ee0b0ae6958804a88fe9580157587720faf664.camel@j-davis.com

We have tests/modules defined for testing logical decoding, no? If the
intention is to define rm_redo in this test module, I think it's not
required.

> Though I'm also fine just adding a test module to start with.

Thanks. I would like to keep it simple.

I've added some more comments and attached v2 patch herewith. Please review.

I've also added a CF entry - https://commitfest.postgresql.org/41/4009/.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com