Re: ps command does not show walsender's connected db

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: bt22nakamorit <bt22nakamorit@oss.nttdata.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-10-10T03:27:31Z
Lists: pgsql-hackers
On Mon, Oct 10, 2022 at 8:00 AM bt22nakamorit
<bt22nakamorit@oss.nttdata.com> wrote:
>
> appendStringInfo will append extra space after null (since "%s "), so
> the ps entry will look less neat in that case.
> How about we check whether port->database_name is null or not, instead
> of making it unconditional?
> It will look like this.
> -    if (!am_walsender)
> +    if (port->database_name != NULL)
>          appendStringInfo(&ps_data, "%s ", port->database_name);

if (port->database_name != NULL && port->database_name[0] != '\0')
    appendStringInfo(&ps_data, "%s ", port->database_name);

The above works better.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



Commits

  1. Add the database name to the ps display of logical WAL senders