correct the sizes of values and nulls arrays in pg_control_checkpoint
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-23T11:39:28Z
Lists: pgsql-hackers
Attachments
- v1-0001-correct-the-sizes-of-values-and-nulls-arrays-in-p.patch (application/octet-stream) patch v1-0001
Hi,
pg_control_checkpoint emits 18 columns whereas the values and nulls
arrays are defined to be of size 19. Although it's not critical,
attaching a tiny patch to fix this.
diff --git a/src/backend/utils/misc/pg_controldata.c
b/src/backend/utils/misc/pg_controldata.c
index 209a20a882..b1db9a8d07 100644
--- a/src/backend/utils/misc/pg_controldata.c
+++ b/src/backend/utils/misc/pg_controldata.c
@@ -79,8 +79,8 @@ pg_control_system(PG_FUNCTION_ARGS)
Datum
pg_control_checkpoint(PG_FUNCTION_ARGS)
{
- Datum values[19];
- bool nulls[19];
+ Datum values[18];
+ bool nulls[18];
TupleDesc tupdesc;
HeapTuple htup;
ControlFileData *ControlFile;
Regards,
Bharath Rupireddy.
Commits
-
Fix incorrect field count in pg_control_checkpoint()
- 86d9888d2ead 15.0 landed
-
Fix pg_control_checkpoint from commit 4b0d28de06
- 2ede45c3a49e 11.0 cited
-
Remove secondary checkpoint
- 4b0d28de06b2 11.0 cited