Re: Simplify backend terminate and wait logic in postgres_fdw test

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Fujii Masao <masao.fujii@oss.nttdata.com>
Date: 2021-05-04T13:50:44Z
Lists: pgsql-hackers
On Tue, May 4, 2021 at 7:05 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Michael Paquier <michael@paquier.xyz> writes:
> > (Worth noting that I am out this week for Golden Week, so if this can
> > wait until Monday, that would be nice.  I am not willing to take my
> > chances with the buildfarm now :p)
>
> I will see to it.  I think it's important to get a fix in in the next
> couple of days, because hyrax has not had a clean run in six weeks.
> That animal takes almost a week per test cycle, so the next HEAD run
> it starts (two or three days from now) is about our last chance to
> get it to go green before beta1 wrap.  I feel it's fairly urgent to
> try to do that, because who knows if any other cache-clobber issues
> snuck in just before feature freeze.

Thanks! Can we then take the patch proposed at [1]?

[1] - https://www.postgresql.org/message-id/CALj2ACWqh2nHzPyzP-bAY%2BCaAAbtQRO55AQ_4ppGiU_w8iOvTg%40mail.gmail.com

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com



Commits

  1. Disable cache clobber to avoid breaking postgres_fdw termination test.

  2. Simplify tests of postgres_fdw terminating connections

  3. Add functions to wait for backend termination

  4. postgres_fdw: Fix tests for CLOBBER_CACHE_ALWAYS.