Re: Avoid memory leaks during base backups
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Date: 2022-09-28T09:30:30Z
Lists: pgsql-hackers
Attachments
- v2-0001-Avoid-memory-leaks-during-backups.patch (application/x-patch) patch v2-0001
On Wed, Sep 28, 2022 at 10:09 AM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote: > > Here's what I think - for backup functions, we > can have the new memory context child of TopMemoryContext and for > perform_base_backup(), we can have the memory context child of > CurrentMemoryContext. With PG_TRY()-PG_FINALLY()-PG_END_TRY(), we can > delete those memory contexts upon ERRORs. This approach works for us > since backup-related code doesn't have any FATALs. > > Thoughts? I'm attaching the v2 patch designed as described above. Please review it. I've added an entry in CF - https://commitfest.postgresql.org/40/3915/ -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Commits
-
Improve memory handling across SQL-callable backup functions
- 6cc66197ff9a 16.0 landed