Re: Switching XLog source from archive to streaming when primary available

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>

Cc: nathandbossart@gmail.com, cary.huang@highgo.ca, pgsql-hackers@lists.postgresql.org, satyanarlapuram@gmail.com

Date: 2022-09-19T14:19:21Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add basic TAP tests for the low-level backup method, take two
- 071e3ad59d6f 17.0 cited
Add a failover option to subscriptions.
- 776621a5e479 17.0 cited
Make all Perl warnings fatal
- c5385929593d 17.0 cited
Add PostgreSQL::Test::Cluster::advance_wal
- c161ab74f76a 17.0 cited
Rename wal_keep_segments to wal_keep_size.
- c3fe108c025e 14.0 cited

Attachments

v7-0001-Allow-standby-to-switch-WAL-source-from-archive-t.patch (application/x-patch) patch v7-0001

On Fri, Sep 16, 2022 at 4:58 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Fri, Sep 16, 2022 at 12:06 PM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
> >
> > In other words, it seems to me that the macro name doesn't manifest
> > the condition correctly.
> >
> > I don't think we don't particularly want to do that unconditionally.
> > I wanted just to get rid of the macro from the usage site.  Even if
> > the same condition is used elsewhere, I see it better to write out the
> > condition directly there..
>
> I wanted to avoid a bit of duplicate code there. How about naming that
> macro IsXLOGSourceSwitchToStreamEnabled() or
> SwitchFromArchiveToStreamEnabled() or just SwitchFromArchiveToStream()
> or any other better name?

SwitchFromArchiveToStreamEnabled() seemed better at this point. I'm
attaching the v7 patch with that change. Please review it further.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com