Re: Logical Replication - behavior of ALTER PUBLICATION .. DROP TABLE and ALTER SUBSCRIPTION .. REFRESH PUBLICATION
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: japin <japinli@hotmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "Hou,
Zhijie" <houzj.fnst@cn.fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-15T11:55:44Z
Lists: pgsql-hackers
Attachments
- v3-0002-Test-behaviour-of-ALTER-PUBLICATION-.-DROP-TABLE.patch (application/octet-stream) patch v3-0002
On Fri, Jan 15, 2021 at 4:54 PM japin <japinli@hotmail.com> wrote: > On Fri, 15 Jan 2021 at 18:57, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote: > > On Fri, Jan 15, 2021 at 4:03 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > >> That sounds like a better way to fix and in fact, I was about to > >> suggest the same after reading your previous email. I'll think more on > >> this but in the meantime, can you add the test case in the patch as > >> requested earlier as well. > > > > @Li Japin Please let me know if you have already started to work on > > the test case, otherwise I can make a 0002 patch for the test case and > > post. > > > > Yeah, I'm working on the test case. Since I'm not familair with the logical > replication test, it may take some times. Thanks a lot. I quickly added the initial use case where we saw the bug, attached is 0002 patch. Please have a look and add further use cases if necessary. If okay, it's better to make a cf entry. I have one comment in v3-0001 patch, + * There might some relations dropped from the publication, we do I think we should change it to - "There might be some relations". With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
Commits
-
Fix ALTER PUBLICATION...DROP TABLE behavior.
- 40ab64c1ec1c 14.0 landed
-
Fix initialization of RelationSyncEntry for streaming transactions.
- 69bd60672af6 14.0 cited