Horton

Thread

Commits

  1. Fix use of wrong variable in pg_receivewal's get_destination_dir().

  1. Fix a typo in pg_receivewal.c's get_destination_dir()

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2022-02-26T16:34:13Z

    Hi,

It looks like there's a typo in pg_receivewal.c's
get_destination_dir(), that is, use the function parameter dest_folder
instead of global variable basedir in the error message. Although
there's no harm in it as basedir is a global variable in
pg_receivewal.c, let's use the function parameter to be in sync with
close_destination_dir.

Attaching a tiny patch to fix it.

Regards,
Bharath Rupireddy.

  2. Re: Fix a typo in pg_receivewal.c's get_destination_dir()

    Andres Freund <andres@anarazel.de> — 2022-02-27T00:46:37Z

    Hi,

On 2022-02-26 22:04:13 +0530, Bharath Rupireddy wrote:
> It looks like there's a typo in pg_receivewal.c's
> get_destination_dir(), that is, use the function parameter dest_folder
> instead of global variable basedir in the error message. Although
> there's no harm in it as basedir is a global variable in
> pg_receivewal.c, let's use the function parameter to be in sync with
> close_destination_dir.
> 
> Attaching a tiny patch to fix it.

Good catch, pushed.

Greetings,

Andres Freund