Re: Is Recovery actually paused?

On Mon, Jan 25, 2021 at 2:53 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> I have changed as per other functions for consistency.

Thanks for the v7 patch. Here are some quick comments on it:

[1] I think we need to change return value from boolean to text in
documentation:
      <primary>pg_is_wal_replay_paused</primary>
        </indexterm>
        <function>pg_is_wal_replay_paused</function> ()
        <returnvalue>boolean</returnvalue>
       </para>

[2] Do we intentionally ignore the return type of below function? If
yes, can we change the return type to void and change the function
comment? If we do care about the return value, shouldn't we use it?

static bool recoveryApplyDelay(XLogReaderState *record);
+                recoveryApplyDelay(xlogreader);

[3] Although it's not necessary, I just thought, it will be good to
have an example for the new output of pg_is_wal_replay_paused in the
documentation, something like below for brin_page_type:

<screen>
test=# SELECT brin_page_type(get_raw_page('brinidx', 0));
 brin_page_type
----------------
 meta
</screen>

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com