Horton

Re: Improvements and additions to COPY progress reporting

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

View thread View on postgr.es
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>, Michael Paquier <michael@paquier.xyz>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Josef Šimánek <josef.simanek@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-04T06:51:40Z
Lists: pgsql-hackers 
On Wed, Feb 24, 2021 at 1:23 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> On Sun, Feb 21, 2021 at 08:10:09PM +0100, Matthias van de Meent wrote:
> > Subject: [PATCH v9 1/3] Add progress-reported components for COPY progress
> >  reporting
>
> >                       /* Increment amount of processed tuples and update the progress */
> >       /* Increment amount of processed tuples and update the progress */
>
> Ideally, this would say "number of processed tuples"

Correct. It's introduced by the original COPY progress reporting
patch. Having said that, we could just correct them in the 0001 patch.

> Looking at the existing docs:
>
> https://www.postgresql.org/docs/devel/progress-reporting.html#COPY-PROGRESS-REPORTING
> | OID of the table on which the COPY command is executed
>
> Maybe it should say ".. is executing".  Or ".. being executed":
> | OID of the table on which the COPY command is being executed

+1 for changing it to "OID of the table on which the COPY command is
being executed."

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Add some basic tests for progress reporting of COPY

  2. Add support for more progress reporting in COPY

  3. doc: Add backlinks to progress reporting documentation