Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-09-11T08:28:42Z

Lists: pgsql-hackers

Attachments

v1-0001-replication-slots-remove-duplicate-code-for-check.patch (application/octet-stream) patch v1-0001

Hi,

We have two static check_permissions functions (one in slotfuncs.c
another in logicalfuncs.c) with the same name and same code for
checking the privileges for using replication slots. Why can't we have
a single function CheckReplicationSlotPermissions in slot.c? This way,
we can get rid of redundant code. Attaching a patch for it.

Thoughts?

Regards,
Bharath Rupireddy.

Commits

Remove code duplication for permission checks with replication slots
- 026ed8efd6b1 15.0 landed
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited