Re: Make all Perl warnings fatal

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

View thread View on postgr.es

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-01-16T11:08:47Z

Lists: pgsql-hackers

Attachments

v1-0001-Fix-an-issue-in-PostgreSQL-Test-Cluster-psql.patch (application/octet-stream) patch v1-0001

On Fri, Jan 12, 2024 at 9:21 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Fri, Jan 12, 2024 at 9:03 PM Peter Eisentraut <peter@eisentraut.org> wrote:
> >
> > I would put this code
> >
> >      my $core = $ret & 128 ? " (core dumped)" : "";
> >      die "psql exited with signal "
> >        . ($ret & 127)
> >        . "$core: '$$stderr' while running '@psql_params'"
> >        if $ret & 127;
> >      $ret = $ret >> 8;
> >
> > inside a if (defined $ret) block.
> >
> > Then the behavior would be that the whole function returns undef on
> > timeout, which is usefully different from returning 0 (and matches
> > previous behavior).
>
> WFM.

I've attached a patch for the above change.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

Add missing FATAL => 'all' to a use warnings in Perl
- 014720c6d9fb 18.0 landed
Make all Perl warnings fatal in 043_wal_replay_wait.pl
- e1555645d729 18.0 landed
Add tap test for pg_signal_autovacuum role
- d2b74882cab8 18.0 cited
Implement pg_wal_replay_wait() stored procedure
- 06c418e163e9 17.0 cited
Fix an issue in PostgreSQL::Test::Cluster:psql()
- 686db12de3a0 17.0 landed
Make all Perl warnings fatal
- c5385929593d 17.0 landed
Fix a warning in Perl test code
- a7ebd82b9e50 17.0 landed
Avoid use of Perl getprotobyname
- 01226c682ce6 17.0 landed