Re: Support worker_spi to execute the function dynamically.

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

View thread View on postgr.es

From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

To: Masahiro Ikeda <ikedamsh@oss.nttdata.com>

Cc: michael@paquier.xyz, pgsql-hackers@lists.postgresql.org

Date: 2023-07-24T03:01:01Z

Lists: pgsql-hackers

Attachments

v3-0001-Add-TAP-tests-to-worker_spi-module.patch (application/octet-stream) patch v3-0001

On Mon, Jul 24, 2023 at 6:34 AM Masahiro Ikeda <ikedamsh@oss.nttdata.com> wrote:
>
> OK. If so, we need to remove the following comment in Makefile.
>
> > # enable our module in shared_preload_libraries for dynamic bgworkers

Done.

> I also confirmed that the tap tests work with meson and make.

Thanks for verifying.

I also added a note atop worker_spi.c that the module also
demonstrates how to write core (SQL) tests and extended (TAP) tests.

I'm attaching the v3 patch.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

worker_spi: Fix race condition in newly-added TAP tests
- b68e356a680e 17.0 landed
worker_spi: Switch to TAP tests
- 320c311fda91 17.0 landed
worker_spi: Use term "dynamic" for bgworkers launched with worker_spi_launch()
- d9eb92c7b122 17.0 landed
Fix worker_spi when launching workers without shared_preload_libraries
- 97ff8dd02ca7 17.0 landed