Re: Orphaned wait event

On Fri, Mar 24, 2023 at 12:00 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Fri, Mar 24, 2023 at 3:31 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> >
> > On Thu, Mar 23, 2023 at 8:10 PM Bharath Rupireddy
> > <bharath.rupireddyforpostgres@gmail.com> wrote:
> > > Yeah, commit [1] removed the last trace of it. I wonder if we can add
> > > a WAIT_EVENT_SLRU_FLUSH_SYNC wait event in SlruSyncFileTag(), similar
> > > to mdsyncfiletag. This way, we would have covered all sync_syncfiletag
> > > fsyncs with wait events.
> >
> > Ahh, right.  Thanks.  The mistake was indeed that SlruSyncFileTag
> > failed to report it while running pg_fsync().
>
> Thanks. The attached patch looks good to me.

It looks like this patch attached upthread at [1] isn't in yet,
meaning WAIT_EVENT_SLRU_FLUSH_SYNC stays unused. IMO, it's worth
pushing it to the PG16 branch. It will help add a wait event for SLRU
page flushes. Thoughts?

[1] https://www.postgresql.org/message-id/CA%2BhUKG%2BewEpxm%3DhPNXyupRUB_SKGh-6tO86viaco0g-P_pm_Cw%40mail.gmail.com

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com