Horton

Thread

Commits

  1. Clean up some includes and comments in TAP test scripts

  1. Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2022-05-21T07:38:37Z

    Hi,

While working on a feature, I noticed that there are unnecessary
includes of "use File::Path qw(rmtree);" in some TAP test files and
also some wrong comments in 019_replslot_limit.pl. Attaching a patch
to fix these.

Regards,
Bharath Rupireddy.

  2. Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl

    Maxim Orlov <orlovmg@gmail.com> — 2022-07-06T13:05:03Z

    Hi!

This is an obvious change, I totally for it. Hope it will be commited soon.

-- 
Best regards,
Maxim Orlov.

  3. Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl

    Pavel Borisov <pashkin.elfe@gmail.com> — 2022-07-06T13:22:14Z

    On Wed, Jul 6, 2022 at 5:05 PM Maxim Orlov <orlovmg@gmail.com> wrote:

> Hi!
>
> This is an obvious change, I totally for it. Hope it will be commited soon.
>

I'm sorry for some nitpicking about changes in the comments:
- The number of WAL segments advanced hasn't changed from 5 to 1, it just
advances as 1+4 as previously. So the original comment is right. I reverted
this in v2.
- wal_segment_size is in bytes so comment "(wal_segment_size * n) MB" is
incorrect. I corrected this to bytes.

PFA  v2 of a patch (only comments changed/reverted to original).
Overall I completely agree with Maxim: the patch is good and simple enough
to be RfC.

-- 
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

  4. Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl

    Maxim Orlov <orlovmg@gmail.com> — 2022-07-06T13:26:38Z

    >
> I'm sorry for some nitpicking about changes in the comments:
> - The number of WAL segments advanced hasn't changed from 5 to 1, it just
> advances as 1+4 as previously. So the original comment is right. I reverted
> this in v2.
>

Yeah, it looks even better now.

-- 
Best regards,
Maxim Orlov.

  5. Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl

    Michael Paquier <michael@paquier.xyz> — 2022-07-07T01:24:40Z

    On Wed, Jul 06, 2022 at 04:26:38PM +0300, Maxim Orlov wrote:
> Yeah, it looks even better now.

Especially knowing that the test uses a segment size of 1MB via initdb
to be cheaper.  v2 looks fine by itself, so applied.
--
Michael

  6. Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl

    Pavel Borisov <pashkin.elfe@gmail.com> — 2022-07-07T08:50:00Z

    >
> Especially knowing that the test uses a segment size of 1MB via initdb
> to be cheaper.  v2 looks fine by itself, so applied.
>

Thanks, Michael!

-- 
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>