Horton

Re: Comment typo in tableam.h

Ashwin Agrawal <aagrawal@pivotal.io>

View thread View on postgr.es
From: Ashwin Agrawal <aagrawal@pivotal.io>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>, Antonin Houska <ah@cybertec.at>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-07-08T16:51:34Z
Lists: pgsql-hackers 
On Sat, Jul 6, 2019 at 12:05 AM Amit Kapila <amit.kapila16@gmail.com> wrote:

> On Tue, Jul 2, 2019 at 1:00 AM Ashwin Agrawal <aagrawal@pivotal.io> wrote:
> > Please find attached v2 of patch 1 without objectionable comment change.
> v1 of patch 2 attaching here just for convenience, no modifications made to
> it.
> >
>
> 0001*
>   * See table_index_fetch_tuple's comment about what the difference between
> - * these functions is. This function is the correct to use outside of
> - * index entry->table tuple lookups.
> + * these functions is. This function is correct to use outside of index
> + * entry->table tuple lookups.
>
> How about if we write the last line of comment as "It is correct to
> use this function outside of index entry->table tuple lookups."?  I am
> not an expert on this matter, but I find the way I am suggesting
> easier to read.
>

I am fine with the way you have suggested.

Commits

  1. tableam: comment improvements.

  2. Fix few typos and minor word smithing in tableam comments.

  3. Fix few typos and minor wordsmithing in tableam comments.

  4. Add missing assertions for required table am callbacks.

  5. Fix incorrect parameter name in comment