Horton

Re: Inconsistency between table am callback and table function names

Ashwin Agrawal <aagrawal@pivotal.io>

View thread View on postgr.es
From: Ashwin Agrawal <aagrawal@pivotal.io>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2019-05-24T16:40:46Z
Lists: pgsql-hackers 
On Thu, May 23, 2019 at 4:32 PM Andres Freund <andres@anarazel.de> wrote:

> Hi,
>
> On 2019-05-14 12:11:46 -0700, Ashwin Agrawal wrote:
> > Thank you. Please find the patch to rename the agreed functions. It would
> > be good to make all consistent instead of applying exception to three
> > functions but seems no consensus on it. Given table_ api are new, we
> could
> > modify them leaving systable_ ones as is, but as objections left that as
> is.
>
> I've pushed a slightly modified version (rebase, some additional
> newlines due to the longer function names) now. Thanks for the patch!
>

Thanks a lot Andres. With pg_intend run before the patch on master, I can
imagine possibly generated additional work for you on this.

Commits

  1. tableam: Rename wrapper functions to match callback names.