Horton

Re: Comment typo in tableam.h

Ashwin Agrawal <aagrawal@pivotal.io>

View thread View on postgr.es
From: Ashwin Agrawal <aagrawal@pivotal.io>
To: Andres Freund <andres@anarazel.de>
Cc: David Rowley <david.rowley@2ndquadrant.com>, Antonin Houska <ah@cybertec.at>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-06-04T01:21:56Z
Lists: pgsql-hackers 
On Mon, Jun 3, 2019 at 5:26 PM Andres Freund <andres@anarazel.de> wrote:

> Hi,
>
> Thanks for these!
>
> On 2019-06-03 17:24:15 -0700, Ashwin Agrawal wrote:
> >       /*
> >        * Estimate the size of shared memory needed for a parallel scan
> of this
> > -      * relation. The snapshot does not need to be accounted for.
> > +      * relation.
> >        */
> >       Size            (*parallelscan_estimate) (Relation rel);
>
> That's not a typo?
>

The snapshot is not passed as argument to that function hence seems weird
to refer to snapshot in the comment, as anyways callback function can't
account for it. Seems stale piece of comment and hence that piece of text
should be removed. I should have refereed to changes as general comment
fixes instead of explicit typo fixes :-)

Commits

  1. tableam: comment improvements.

  2. Fix few typos and minor word smithing in tableam comments.

  3. Fix few typos and minor wordsmithing in tableam comments.

  4. Add missing assertions for required table am callbacks.

  5. Fix incorrect parameter name in comment