Re: Inconsistency between table am callback and table function names

Ashwin Agrawal <aagrawal@pivotal.io>

From: Ashwin Agrawal <aagrawal@pivotal.io>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2019-05-10T17:43:44Z
Lists: pgsql-hackers
On Thu, May 9, 2019 at 8:52 AM Andres Freund <andres@anarazel.de> wrote:
> The changes necessary for tableam were already huge. Changing naming
> schemes for functions that are used all over the backend (e.g. ~80 calls
> to table_beginscan), and where there's other wrapper functions that also
> widely used (237 calls to systable_beginscan) which didn't have to be
> touched, at the same time would have made it even harder to review.

If there are no objections to renaming now, as separate independent
patch, I am happy to do the same and send it across. Will rename to
make it consistent as mentioned at start of the thread leaving
table_relation_xxx() ones as is today.



Commits

  1. tableam: Rename wrapper functions to match callback names.