Re: BUG #19026: ResourceOwnerForget can't find owner for invalid plancache

Kirill Reshke <reshkekirill@gmail.com>

From: Kirill Reshke <reshkekirill@gmail.com>

To: Dilip Kumar <dilipbalaut@gmail.com>

Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org

Date: 2025-08-20T13:34:58Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix re-execution of a failed SQLFunctionCache entry.
- a67d4847a431 19 (unreleased) landed
- 906b68217a1e 18.0 landed

On Wed, 20 Aug 2025 at 18:25, Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Wed, Aug 20, 2025 at 5:13 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
> > How about attached?
>
> Thanks, right it's better to clean up in sql_exec_error_callback.  But
> we should still release the cached plan before setting it to NULL in
> order to leak the cache plan as I was doing in my patch.

I am under the impression that we don’t. Resource owner will release
all cached plans in the rollback tx handler.
This can be confirmed via gdb session: print  fcache->cplan in
sql_exec_error_callback and after this plan in ReleaseCachedPlan in
this repro.
These two pointers will be equal

-- 
Best regards,
Kirill Reshke