Re: Enhance file_fdw to report processed and skipped tuples in COPY progress
Kirill Reshke <reshkekirill@gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2024-11-30T06:23:08Z
Lists: pgsql-hackers
On Fri, 11 Oct 2024 at 06:53, Fujii Masao <masao.fujii@oss.nttdata.com> wrote: > However, this issue already exists without the proposed patch. > Since file_fdw already reports progress partially, querying multiple > file_fdw tables can lead to inaccurate or confusing progress reports. > You can even observe this when analyzing a file_fdw table and also > when copying to the table with a trigger that executes progress-reporting > commands. > > So, I don’t think this issue should block the proposed patch. > In fact, progress reporting is already flawed in these scenarios, > regardless of whether the patch is applied. Im +1 on this. To include or not to include these new fields, and to fix multiple-run-bug is two separate topics IMO. Also please notice review comments in[0]. [0] https://www.postgresql.org/message-id/20241011153645.a348de1576a3f57092c68355%40sraoss.co.jp Moved to the next CF. -- Best regards, Kirill Reshke