Horton

Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

Kirill Reshke <reshkekirill@gmail.com>

View thread
From: Kirill Reshke <reshkekirill@gmail.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-22T05:47:37Z
Lists: pgsql-hackers 
On Mon, 22 Dec 2025 at 03:02, Alexander Korotkov <aekorotkov@gmail.com> wrote:
>
> On Sun, Dec 21, 2025 at 9:42 AM Kirill Reshke <reshkekirill@gmail.com> wrote:

> > Hi! Your v2 looks fine
> > The only question for me is, should we add any regression test to exercise this code, or it is not worth the troubles?
>
> I've checked contents of out regression tests.  I see we very rarely
> include SQLSTATE there, mostly in psql and plpgsql tests.  Thus, I
> think we should just fix the SQLSTATE without dedicating a test for
> that.  So, I'm going to push the patch from Tender Wang if no
> objections.


Ok, no objections.


-- 
Best regards,
Kirill Reshke