Horton

Re: Fix gistkillitems & add regression test to microvacuum

Kirill Reshke <reshkekirill@gmail.com>

View thread View on postgr.es
From: Kirill Reshke <reshkekirill@gmail.com>
To: Soumya S Murali <soumyamurali.work@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2026-03-18T05:42:08Z
Lists: pgsql-hackers

Attachments

On Wed, 11 Feb 2026 at 17:18, Soumya S Murali
<soumyamurali.work@gmail.com> wrote:
>
> Hi all,
>
> Thank you for the updated patch.
> I reproduced the issue locally by filling a GiST root page, deleting
> all tuples, and triggering a microvacuum by an index-only scan.
> With the patch, The root page is now handled consistently with other
> leaf pages. so->curBlkno and so->curPageLSN are properly set during
> scan, and gistkillitems() operates safely and correctly on the root
> page.
> Based on runtime validation and code inspection, the fix LGTM.
>



Rebased due to  f5eb854ab6d[0]

I have added a [0]committer to CC.

Andres, can you please take a look at this thread, if by chance you
have spare time for it? You have changed kill tuples-related logic
frequently, so you might be interested...

[0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=f5eb854ab6d6281ec2d3143657944bdda6676341

-- 
Best regards,
Kirill Reshke

Commits

  1. Fix use of wrong variable in _hash_kill_items()