Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
Kirill Reshke <reshkekirill@gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Roman Khapov <rkhapov@yandex-team.ru>, pgsql-hackers@lists.postgresql.org, michael@paquier.xyz
Date: 2025-12-29T19:29:49Z
Lists: pgsql-hackers
On Tue, 30 Dec 2025 at 00:24, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Kirill Reshke <reshkekirill@gmail.com> writes: > > Should we then refactor code to avoid copying? I copied this code in > > [0] for the third time, so if this has a chance to be committed, there > > will be 3 times copied code... > > Might not be a bad idea, but of course the devil is in the details. > What did you have in mind? Split out a function to quote one > field value per record_out's rules? > > regards, tom lane Yes, split out a function that does quoting after OidOutputFunctionCall. that is, this: https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/rowtypes.c#L437-L464 -- Best regards, Kirill Reshke