Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS

Kirill Reshke <reshkekirill@gmail.com>

From: Kirill Reshke <reshkekirill@gmail.com>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-11-04T11:50:50Z

Lists: pgsql-hackers

Attachments

v3-0002-Enhance-tab-completion-to-ALTER-TYPE-ADD-DROP-ATT.patch (application/octet-stream) patch v3-0002
v3-0001-Add-missing-psql-tab-completion-for-som-ALTER-TAB.patch (application/octet-stream) patch v3-0001
v3-0003-Add-missing-tab-completion-for-CREATE-TEMP-TABLE-.patch (application/octet-stream) patch v3-0003

On Fri, 1 Nov 2024 at 15:43, Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> Hi hackers!
>
> I have been working on cloudberry/greenplum tab completion features,
> and I spotted that the postgres version of psql does not tab-complete
> ALTER TABLE ADD COLUMN IF NOT EXISTS pattern.
> So, I propose to support this.
>
> --
> Best regards,
> Kirill Reshke
Hi, I spotted another missing option:

CREATE TEMP TABLE <name> (...) does not complete with USING.
I suspect the reason is that commit 4cba9c2, which added this tab
completion, was before TAM support.

So, sending this enhancement (v3-0003) along with two other patches.

-- 
Best regards,
Kirill Reshke

Commits

psql: Tab completion for CREATE MATERIALIZED VIEW ... USING
- de1e29885730 18.0 landed
psql: Tab completion for CREATE TEMP TABLE ... USING
- 1e1f70c34a8e 18.0 landed
psql: Tab completion for ALTER TYPE ... CASCADE/RESTRICT
- 8f11ef80c545 18.0 landed
psql: Tab completion for ALTER TYPE ... ADD ATTRIBUTE
- e0275c380c3f 18.0 landed
Add more tab completion for CREATE TABLE in psql
- 4cba9c2a33f1 12.0 cited