Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS

Kirill Reshke <reshkekirill@gmail.com>

View thread View on postgr.es

From: Kirill Reshke <reshkekirill@gmail.com>

To: Tomas Vondra <tomas@vondra.me>

Cc: Karina Litskevich <litskevichkarina@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-12-08T04:22:53Z

Lists: pgsql-hackers

Attachments

v6-0003-Add-missing-tab-completion-for-CREATE-TEMP-TABLE-.patch (application/octet-stream) patch v6-0003
v6-0001-Enhance-tab-completion-to-ALTER-TYPE-ADD-ATTRIBUT.patch (application/octet-stream) patch v6-0001
v6-0002-Add-CASCADE-RESRTICT-to-ALTER-TYPE-patterns.patch (application/octet-stream) patch v6-0002
v6-0004-Suggest-table-access-method-for-create-maateriali.patch (application/octet-stream) patch v6-0004

On Sun, 8 Dec 2024 at 03:35, Tomas Vondra <tomas@vondra.me> wrote:
>
> Hi,
> I took a quick look at this patch series, and it looks generally fine to
> me. Barring objections, I'll get it committed. Yes, there's a couple
> cosmetic details, and it needs a pgindent run, but I think I can take
> care of that ...
>
Thank you for taking a look.

PFA v6 with last Karina's review comments addressed.

-- 
Best regards,
Kirill Reshke

Commits

psql: Tab completion for CREATE MATERIALIZED VIEW ... USING
- de1e29885730 18.0 landed
psql: Tab completion for CREATE TEMP TABLE ... USING
- 1e1f70c34a8e 18.0 landed
psql: Tab completion for ALTER TYPE ... CASCADE/RESTRICT
- 8f11ef80c545 18.0 landed
psql: Tab completion for ALTER TYPE ... ADD ATTRIBUTE
- e0275c380c3f 18.0 landed
Add more tab completion for CREATE TABLE in psql
- 4cba9c2a33f1 12.0 cited